[
https://issues.apache.org/jira/browse/BIGTOP-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245986#comment-14245986
]
RJ Nowling commented on BIGTOP-1273:
------------------------------------
[~jayunit100] Clean up sounds great. I like the additional comments. I don't
see where JavaConversions is used or where the maps were added -- were you
thinking of using them with the for loops for generating stores and customers?
If so, I think that would be great. I had the problem that the data generator
API requires Java Collections interfaces while Spark requires Scala lists. If
you can mitigate it so that we only need one type of list, that would be
awesome.
Two things from the code:
1. There's an empty comment line on 191
2. The comment styles are inconsistent in the file. I'm fine with either style
-- can you convert all of them to a style of your choice?
> BigPetStore: Cleanup formatting.
> ---------------------------------
>
> Key: BIGTOP-1273
> URL: https://issues.apache.org/jira/browse/BIGTOP-1273
> Project: Bigtop
> Issue Type: Improvement
> Components: blueprints
> Reporter: jay vyas
> Fix For: backlog
>
>
> Lets clean up the formatting according to whats been outlined in BIGTOP-1240.
> - mark non-production code accordingly
> - imrpove any obvious typos etc
> - delete dead code
> - run formatting against
> In the process I think we can put in some light improvement of docs / READMEs
> where necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
