[
https://issues.apache.org/jira/browse/BIGTOP-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247543#comment-14247543
]
RJ Nowling edited comment on BIGTOP-1273 at 12/16/14 1:10 AM:
--------------------------------------------------------------
Hi [~jayunit100]
Comments by line number:
54: I think the argument-parsing code is verbose. However, if we're gonna
change it, we also need to change it in the ETL script so that everything is
consistent. I'd like to keep everything consistent.
89: Not optional. The user can provide N (with seed) or N - 1 (no seed)
parameters.
142: For each group of customers, we:
* Create a new RNG
* Generate a purchasing profile
* Generate transactions for the given time period
* Return a list of transactions for each customer, flattening the transactions
so that we return a single list for the group
150: Indentation needs to be fixed
161-164: Alignment is off
198: Should add a blank line after this?
206: Comment style doesn't match other multi-line comments :)
213: Add whitespace between map and {
224: Semi colon isn't needed
234: There should be a blank line between text and params.
228: Yes, saveAsTextFile() is distributed. Call's Hadoop's I/O system under
the hood
Looks good!
was (Author: rnowling):
Hi [~jayunit100]
Comments by line number:
54: I think the argument-parsing code is verbose. However, if we're gonna
change it, we also need to change it in the ETL script so that everything is
consistent. I'd like to keep everything consistent.
89: Not optional. The user can provide N (with seed) or N - 1 (no seed)
parameters.
142: For each group of customers, we:
* Create a new RNG
* Generate a purchasing profile
* Generate transactions for the given time period
* Return a list of transactions for each customer, flattening the transactions
so that we return a single list for the group
150: Indentation needs to be fixed
198: Should add a blank line after this?
206: Comment style doesn't match other multi-line comments :)
213: Add whitespace between map and {
224: Semi colon isn't needed
234: There should be a blank line between text and params.
228: Yes, saveAsTextFile() is distributed. Call's Hadoop's I/O system under
the hood
Looks good!
> BigPetStore: Cleanup formatting.
> ---------------------------------
>
> Key: BIGTOP-1273
> URL: https://issues.apache.org/jira/browse/BIGTOP-1273
> Project: Bigtop
> Issue Type: Improvement
> Components: blueprints
> Reporter: jay vyas
> Fix For: backlog
>
>
> Lets clean up the formatting according to whats been outlined in BIGTOP-1240.
> - mark non-production code accordingly
> - imrpove any obvious typos etc
> - delete dead code
> - run formatting against
> In the process I think we can put in some light improvement of docs / READMEs
> where necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
