sure ! Makes sense. I will make a more formal email proposal On Thu, Dec 18, 2014 at 12:46 AM, Konstantin Boudnik <[email protected]> wrote: > > Don't get me wrong guys - it's great to have non-committers reviewing the > patches of committers. And it is perhaps ok to make such a +1 to be > sufficient. But thus far we had one set of rules; and if we want to change > them - let's do it with open face via proper discussions, etc. > > Does it make sense? > Cos > > On Thu, Dec 18, 2014 at 12:04AM, Jay Vyas wrote: > > Haha ok here is what happened.... > > > > - Normally, if "joe the commiter" writes a patch, "bob the non-commiter" > > +1 is *not* sufficent to commit. > > > > - I was asking if ok to make an exception to that rule, and initially i > think you were ok with it... > > > > - So I broke that rule on the bigtop-1273 commit, based on your email... > > > > - But then after cos said he's not quite so sure it's a good rule to > subvert, which is understandable.... > > > > Summary: So I'll for now continue getting commiter +1s for my patches :) > > > > Not a problem :)... Just thought I'd pose the question. > > > > > On Dec 17, 2014, at 10:54 PM, Roman Shaposhnik <[email protected]> > wrote: > > > > > >> On Wed, Dec 17, 2014 at 7:49 PM, jay vyas < > [email protected]> wrote: > > >> no prob @cos... > > >> okay , i commited the last jira w/ rj's +1... > > >> but from now on, ill go back to wait on commiter +1's > > > > > > Jay, you +1ed it, right. So why is there a problem? > > > > > > Thanks, > > > Roman. >
-- jay vyas
