I don't think know that my work meets the necessary requirements. I'm focused primarily on BigPetStore, not the larger code base, while others such as Evan have contributed more than I have and more broadly to the core code base than I have yet they aren't committers yet.
Just my two cents... > On Dec 20, 2014, at 6:54 PM, Bruno Mahé <[email protected]> wrote: > > Why not make RJ a commiter? > > From my understanding a review has at least 2 parts: > 1/ Is the intended change correct. > 2/ Does this change fit into the project's standards, culture. > > A change may perfectly be correct from a 1/ perspective but may require some > changes because of some issues related to 2/ > > Thanks, > Bruno > >> On 12/17/2014 12:21 PM, jay vyas wrote: >> Hi bigtop. >> >> Is it okay for us to commit bigtop-bigpetstore/ updates if RJ +1's them ? >
