[ 
https://issues.apache.org/jira/browse/BIGTOP-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281949#comment-14281949
 ] 

jay vyas commented on BIGTOP-1608:
----------------------------------

Hi david.   I think its time to add itest source dependency as the top level 
dependency.  that way we don't need to reference a version at all.  

I added itest source dependency into the {{mapreduce}} smoke tests.  I think we 
can easily bump that up to the top level gradle file, do you agree ? 
{noformat}
 40 
 41 sourceSets {
 42   main {
 43      groovy {
 44        srcDirs = [
 45          
"$System.env.BIGTOP_HOME"+"/bigtop-test-framework/src/main/groovy/org/apache/bigtop/itest/",
 46          
"$System.env.BIGTOP_HOME"+"/bigtop-test-framework/src/test/groovy/org/apache/bigtop/itest/"
 47         ]
 48    }
 49   }
{noformat}

Then we can eliminate ITEST as an environmental variable entirely, and just run 
it from source, so that smoke-tests always has the up to date ITEST libraries. 

- [~dcapwell] : Shall we move the itest source inclusion to top level gradle, 
and eliminate ITEST var, for  the direction of this patch ? 
- [~cos] does that answer your other question about it being a derivative of 
bigtop home ? Indeed, you were right, but i only implemented this for 
mapreduce/ tests, not glbally.


> smoke-tests dont have BIGTOP_HOME in checkEnv
> ---------------------------------------------
>
>                 Key: BIGTOP-1608
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1608
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: tests
>            Reporter: David Capwell
>            Assignee: David Capwell
>         Attachments: BIGTOP-1608.1.patch
>
>
> If you try to run the smoke tests without setting {{BIGTOP_HOME}} they will 
> run and be unable to find tests, so nothing runs. This variable should be 
> added to checkEnv to make sure its present while running



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to