[ 
https://issues.apache.org/jira/browse/BIGTOP-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298935#comment-14298935
 ] 

Evans Ye commented on BIGTOP-1634:
----------------------------------

No prob [~michaelweiser]. Let's work together to get this in.
I forgot to mention that there was a change I made to make it works. Here's the 
original error I got:
{code}
Error: suffix(): expected first argument to be an Array, got "/data/1" at 
/bigtop-home/bigtop-deploy/puppet/modules/hadoop/manifests/init.pp:149 on node 
bigtop1.docker
{code}
I updated *$hadoop::hadoop_storage_dirs[0]* to *$hadoop::hadoop_storage_dirs*, 
then it works.
But I don't know if this is the logic you want, maybe you can confirm with me.
I can successfully reach the end of puppet apply w/o errors now.
Here's my */etc/puppet/hieradata/site.yaml* in case someone is also interesting 
in this:
{code}
bigtop::hadoop_head_node: "bigtop1.docker"
hadoop::hadoop_storage_dirs:
- "/data/1"
- "/data/2"
Bigtop::bigtop_yumrepo_uri: 
"http://bigtop01.cloudera.org:8080/view/Releases/job/Bigtop-0.8.0/label=centos6/6/artifact/output/";
hadoop_cluster_node::cluster_components:
  - hadoop
  - yarn
bigtop::jdk_package_name: "java-1.7.0-openjdk-devel.x86_64"
{code}

However, if I do not specify components in config, hence deploying all, I got 
the following error:
{code}
Error: Could not find resource 'Service[tachyon-master]' for relationship on 
'Service[tachyon-worker]' on node bigtop1.docker
{code}
I'm not sure whether that is related to this patch. I'll look into this, or 
maybe [~jayunit100] can take a glance on it:)

Getting back to this patch, I'll go further to test the journal based HA. This 
is the huge improvement we'd like to have, making me really excited about 
trying it:)

> Puppet class parameter and hiera conversion
> -------------------------------------------
>
>                 Key: BIGTOP-1634
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1634
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: backlog
>            Reporter: Michael Weiser
>              Labels: patch
>         Attachments: 
> 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch, 
> 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch, 
> 0002-BIGTOP-1634-Add-enhanced-configuration.patch
>
>
> As discussed on the DEV list:
> Update the puppet code to use self-contained, parametrised classes and proper 
> scoping. Replace all extlookup calls bei either explicit or automatic hiera 
> parameter lookups. Implement HA/non-HA alternative via hiera lookup 
> hierarchy. Replace append_each from bigtop_util by suffix from stdlib. Do 
> file imports via puppet:/// scheme. Remove bigtop_util because remaining 
> function get_settings is not needed any more.
> Additionally: Add additional configuration options for zookeeper and yarn as 
> well as a new class for journalnode configuration.
> I've separated it into two patches of ease of review:
> 0001: actual hiera/class conversion
> 0002: functional enhancements including journalnode configuration on top of 
> that. Mainly meant as an example for ease of further expansion and 
> containment of changes to single modules.
> This JIRA is meant for the stuff contained in 0001, the actual hiera 
> conversion. I can resubmit 0002 as a separate JIRA if desired. Also it should 
> be possible to backport 0002 to the current puppet code base without much 
> fuss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to