[
https://issues.apache.org/jira/browse/BIGTOP-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305714#comment-14305714
]
Michael Weiser commented on BIGTOP-1634:
----------------------------------------
{quote}While journaling of HDFS is the new feature potentially will be
added.{quote}
As said at the very top: Journalling can certainly be split out into a separate
jira to trim down the size of this change.
{quote}Would you like to get on the boat of maintainers?{quote}
I should be around for triaging fallout of this change for at least the next
six months. I can not, however, promise continued involvement in Bigtop since
the project we're doing has a limited time frame after which I'll most likely
have to move on to other things.
{quote}Can we retain the logic to support comma separated string{quote}
That's certainly possible. We'd have to add code for all arrays to check if
they're comma-separated strings and split them at the commas. The downside is
that it would add quite some code or a custom function because up to now all
the comma-separated lists in site.csv were actually just extlookup()'s way of
representing arrays and would end up as arrays in puppet (with the exception of
single-item lists). So it'd basically be a step backwards in terms of elegance
and reduction of complexity to support the native format of extlookup for
expressing arrays in yaml which already has a syntax for exactly the same thing.
Could we perhaps just supply a small script for converting site.csvs into
site.yamls or generating site.yamls from command line parameters? It should be
trivial and could be added as a one-liner to vagrant and docker scripts.
> Puppet class parameter and hiera conversion
> -------------------------------------------
>
> Key: BIGTOP-1634
> URL: https://issues.apache.org/jira/browse/BIGTOP-1634
> Project: Bigtop
> Issue Type: Improvement
> Components: deployment
> Affects Versions: backlog
> Reporter: Michael Weiser
> Labels: patch
> Attachments:
> 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch,
> 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch,
> 0002-BIGTOP-1634-Add-enhanced-configuration.patch
>
>
> As discussed on the DEV list:
> Update the puppet code to use self-contained, parametrised classes and proper
> scoping. Replace all extlookup calls bei either explicit or automatic hiera
> parameter lookups. Implement HA/non-HA alternative via hiera lookup
> hierarchy. Replace append_each from bigtop_util by suffix from stdlib. Do
> file imports via puppet:/// scheme. Remove bigtop_util because remaining
> function get_settings is not needed any more.
> Additionally: Add additional configuration options for zookeeper and yarn as
> well as a new class for journalnode configuration.
> I've separated it into two patches of ease of review:
> 0001: actual hiera/class conversion
> 0002: functional enhancements including journalnode configuration on top of
> that. Mainly meant as an example for ease of further expansion and
> containment of changes to single modules.
> This JIRA is meant for the stuff contained in 0001, the actual hiera
> conversion. I can resubmit 0002 as a separate JIRA if desired. Also it should
> be possible to backport 0002 to the current puppet code base without much
> fuss.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
