Can I ask RTC advocate to review a couple of patches to unblock me?
BIGTOP-2025
BIGTOP-2051
Thank you very much!
Cos
On Mon, Sep 14, 2015 at 11:32AM, Konstantin Boudnik wrote:
> On Mon, Sep 14, 2015 at 07:35PM, Olaf Flebbe wrote:
> > Sorry, I haven't followed the initial discussion since I was not onboard at
> > that time.
> >
> > From my view bigtop is the fastest moving project, I ever knew. I am active
> > for over 20 years in all kinds of opensource projects, but bigtops tops them
> > all in speed, second fastest maybe samba and linux kernel at 0.0x
>
> That's so good to hear! Made my day, if not the whole week! Speaks tons about
> the community we have on this project!
>
> > I am strongly oppose [i.e. -1] the CTR style, since I think the project --
> > and myself -- take large benefits from discussions about implementing the
> > best solution for the project.
>
> I think CTR doesn't mean that one can not ever ask for a code review upfront.
> It's all about trusting the developers to do what's the best for the project
> without hanging out high and dry in some obvious cases.
>
> > Getting a +1 is not only that a patch simply runs, it is about code style,
> > architectural decisions. Even a one-liner patch can break designs.
>
> And that again falls back to the point of trusting the judgement of your peers
> to do the "right thing" and come forward with the discussion before making the
> changes that are questionable or contraversial. And we won't know if it works
> before we try it at least for some time ;)
>
> Cos
>
> > I think a clear review guideline would help bigtop more that a commit
> > policy change.
> >
> > Olaf
> >
> >
> >
> >
>
>
