I don't submit much code nowadays, but I do mentor a few students here and there who are contributing to BigTop. For them I think they really enjoy the PR process.
I do as well... In the past I have had to do reviews to use things like "review board" which require us to diff patches using a website and then manually add links to the jira, I think that's even worse. So I don't want to make a vote because I think active contributors should vote, but that is just my opinion: pull requests are easy and lovely esp for complex patches , and esp for onboarding new developers. The latter (onboarding new developers) is the most important reason I think. > On Mar 5, 2016, at 12:21 PM, Olaf Flebbe <[email protected]> wrote: > > Hi, > > can we turn off the JIRA integration of "github pull requests"? > > I am fine with using github, from a developer perspective. The tooling on > github itself is very straight forward. > > But the integration is a big mess. The workflow to review and commit github > requests for BIGTOP seems clumsy to me. > See for instance BIGTOP-2285: It is very hard to sort out comments from > actual code... > > I totally favour a clean patch file documented in JIRA in contrast to an pull > request from an external system with an incomprehensible interface. > > Any other opinions? > Olaf
