I like the integration because the PR(patch) submission is way much easier than formating a patch. It's not that much different if you already familiar the manual process, but It matters for newbie. I don't like the mess of comments it make on JIRAs as well. It turns our JIRA comments from full of intelligence into full of meaningless auto post.
I think the best integration is to just keep the PR submission functionality and eliminate all the other auto posts. However if that's not an easy thing to do, a disable would be better. Jay I'm just asking, is it configurable? 2016-03-07 10:36 GMT+08:00 Roman Shaposhnik <[email protected]>: > FWIW: I'm fine either way. So... I guess +0 > > Thanks, > Roman. > > On Sat, Mar 5, 2016 at 8:49 PM, Andrew Purtell <[email protected]> > wrote: > > I agree. The line by line comments mixed with code posted to jira is a > mess. On the other hand I'm not contributing much these days, so for what > it's worth... > > > >> On Mar 5, 2016, at 7:54 PM, Konstantin Boudnik <[email protected]> wrote: > >> > >> Olaf is complaining about GH-JIRA integration, which is crappy like > hell and I > >> whole-heartedly second this motion. Not a fun of GH however people are > using > >> it. However the way it is polluting the JIRA is beyond crap. > >> > >> Cos > >> > >>> On Sat, Mar 05, 2016 at 12:58PM, Jay Vyas wrote: > >>> I don't submit much code nowadays, but I do mentor a few students here > and > >>> there who are contributing to BigTop. For them I think they really > enjoy > >>> the PR process. > >>> > >>> I do as well... In the past I have had to do reviews to use things > like > >>> "review board" which require us to diff patches using a website and > then > >>> manually add links to the jira, I think that's even worse. > >>> > >>> So I don't want to make a vote because I think active contributors > should > >>> vote, but that is just my opinion: pull requests are easy and lovely > esp for > >>> complex patches , and esp for onboarding new developers. > >>> > >>> The latter (onboarding new developers) is the most important reason I > think. > >>> > >>>> On Mar 5, 2016, at 12:21 PM, Olaf Flebbe <[email protected]> wrote: > >>>> > >>>> Hi, > >>>> > >>>> can we turn off the JIRA integration of "github pull requests"? > >>>> > >>>> I am fine with using github, from a developer perspective. The > tooling on github itself is very straight forward. > >>>> > >>>> But the integration is a big mess. The workflow to review and commit > github requests for BIGTOP seems clumsy to me. > >>>> See for instance BIGTOP-2285: It is very hard to sort out comments > from actual code... > >>>> > >>>> I totally favour a clean patch file documented in JIRA in contrast to > an pull request from an external system with an incomprehensible interface. > >>>> > >>>> Any other opinions? > >>>> Olaf >
