Github user petevg commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/156#discussion_r87495976
--- Diff:
bigtop-packages/src/charm/zookeeper/layer-zookeeper/tests/10-bind-address.py ---
@@ -34,16 +33,16 @@ class TestBindClientPort(unittest.TestCase):
def setUpClass(cls):
cls.d = amulet.Deployment(series='xenial')
- cls.d.add('zookeeper', charm='zookeeper', units=3)
+ cls.d.add('zk-test', charm='cs:xenial/zookeeper')
--- End diff --
Think about this, is this truly the right pattern? I'd generally expect
tests to integrate the code that I was just working on. These tests only
exercise the published code -- if I want to write some code, and then test it,
I have to manually tweak the tests ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
