Github user kwmonroe commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/156#discussion_r87508997
--- Diff:
bigtop-packages/src/charm/zookeeper/layer-zookeeper/tests/10-bind-address.py ---
@@ -34,16 +33,16 @@ class TestBindClientPort(unittest.TestCase):
def setUpClass(cls):
cls.d = amulet.Deployment(series='xenial')
- cls.d.add('zookeeper', charm='zookeeper', units=3)
+ cls.d.add('zk-test', charm='cs:xenial/zookeeper')
--- End diff --
@petevg, i think there was an issue where test tooling might pick a series
that was different than the one given in our Deployment(), so I got in the
habit of being explicit. This did require tweaks to test locally, but it was
better than stuff like cwr using the wrong charm.
This doesn't seem to be needed anymore. Thanks for the catch, and thanks
for improving my local test experience ;)
Fix incoming...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
