Github user kwmonroe commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/208#discussion_r116002658
  
    --- Diff: bigtop-deploy/puppet/manifests/cluster.pp ---
    @@ -72,6 +72,10 @@
         master => ["spark-master"],
         worker => ["spark-worker"],
       },
    +  spark-on-yarn => {
    +    worker => ["spark-on-yarn", "spark-slave"],
    +    client => ["spark-client"],
    +  },
    --- End diff --
    
    Small typo above.  `spark-slave` should be `spark-yarn-slave` (see 
[init.pp](https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/modules/spark/manifests/init.pp#L27)).
    
    Also, while it's probably inconsequential, `spark-yarn-slave` isn't really 
a worker -- it just provides the yarn shuffle jar for spark.  So I think the 
above block should read:
    
    ```diff
    +  spark-on-yarn => {
    +    worker => ["spark-on-yarn"],
    +    client => ["spark-client"],
    +    library => ["spark-yarn-slave"],
    +  },


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to