Github user kwmonroe commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/208#discussion_r116045104
--- Diff: bigtop-deploy/puppet/modules/spark/templates/spark-defaults.conf
---
@@ -13,7 +13,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+<% if @master_url -%>
spark.master <%= @master_url %>
+<% else -%>
+<% if scope['deploy::roles'].include? 'spark-on-yarn' -%>
+spark.master yarn
+<% else -%>
+spark.master spark://<%= @master_host %>:<%= @master_port %>
--- End diff --
Yup @evans-ye, I agree the `spark-master|worker` roles implied standalone,
yet it was always configured for yarn by default. Confusing for sure.
I like your idea of keeping it backwards compat and introducing the new
`spark-standalone`. With that change, I imagine the templates patch would
change to something like this:
```diff
+<% if @master_url -%>
spark.master <%= @master_url %>
+<% else -%>
+<% if scope['deploy::roles'].include? 'spark-standalone' -%>
+spark.master spark://<%= @master_host %>:<%= @master_port %>
+<% else -%>
+spark.master yarn
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
