Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512628
--- Diff: bigtop-tests/smoke-tests/hive/HiveJdbcGeneralTest.java ---
@@ -0,0 +1,87 @@
+
+
+import static org.junit.Assert.assertEquals;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.net.URISyntaxException;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Properties;
+
+import javax.xml.parsers.ParserConfigurationException;
+
+import org.apache.hadoop.fs.Path;
+import org.junit.Test;
+import org.xml.sax.SAXException;
+//Author: Bharat Modi
+
+
+
+public class HiveJdbcGeneralTest extends TestMethods {
+
+ @Test
+ public void testTableCreation() throws SQLException,
+ ClassNotFoundException, InstantiationException,
+ IllegalAccessException, IOException, URISyntaxException,
+ FileNotFoundException, ParserConfigurationException, SAXException {
+ final File f = new
File(HiveJdbcGeneralTest.class.getProtectionDomain().getCodeSource().getLocation().getPath());
--- End diff --
Length of the lines should be kept under 80, if possible. Please check
"REVIEWING PATCHES" section from
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute for more
details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
