Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/266#discussion_r131512767
--- Diff: bigtop-tests/smoke-tests/hive/TestMethods.java ---
@@ -0,0 +1,194 @@
+
+//Author: Bharat Modi
+// A masterclass containing methods which aid in the replication of access
to hadoop
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.ArrayList;
+import java.util.Arrays;
+
+import javax.xml.parsers.DocumentBuilder;
+import javax.xml.parsers.DocumentBuilderFactory;
+import javax.xml.parsers.ParserConfigurationException;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.IOUtils;
+import org.w3c.dom.Document;
+import org.w3c.dom.Element;
+import org.w3c.dom.Node;
+import org.w3c.dom.NodeList;
+import org.xml.sax.SAXException;
+public class TestMethods {
+
+ protected static String propertyValue(String propertyFile, String
propertyName) throws ParserConfigurationException, SAXException, IOException,
URISyntaxException{
--- End diff --
Are these methods have to be `protected static`? Why?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
