Github user buggtb commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/382#discussion_r213245996
--- Diff: bigtop-packages/src/charm/spark/layer-spark/reactive/spark.py ---
@@ -236,7 +235,8 @@ def reconfigure_spark():
# Almost all config changes should trigger a reinstall... except when
# changing the bigtop repo version. Repo version changes require the
user
# to run an action, so we skip the reinstall in that case.
- if not is_state('config.changed.bigtop_version'):
+ if not is_state('config.changed.bigtop_version') \
+ and not is_state('config.changed.spark_enable_thriftserver'):
--- End diff --
"Still, I think the start_thrift method would be nice to refactor to run
@when(spark.started, spark_thrift_enabled) and drop the data_changed logic." <
can you react to a specific config change? I've not noticed that pattern in a
charm before.
I see elsewhere in that charm bigtop.version.changed, but then it doesn't
use that config option to look anything up.
---
