Github user kwmonroe commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/382#discussion_r214484656
--- Diff:
bigtop-packages/src/charm/spark/layer-spark/lib/charms/layer/bigtop_spark.py ---
@@ -400,6 +400,10 @@ def start(self):
else:
hookenv.log("Spark Worker did not start")
+ # Open port for Thrift Server
+ if hookenv.config()['spark_enable_thriftserver']:
--- End diff --
@buggtb yeah, nice catch. I'm +1 to moving `hookenv.open_port` to the
reactive `start_thrift` function, with a `hookenv.close_port` if the config is
false.
---
