elukey commented on a change in pull request #851:
URL: https://github.com/apache/bigtop/pull/851#discussion_r781908136
##########
File path: provisioner/docker/docker-hadoop.sh
##########
@@ -284,12 +293,19 @@ log() {
}
configure-nexus() {
+ get_nodes
for node in ${NODES[*]}; do
docker exec $node bash -c "cd /bigtop-home; ./gradlew -PNEXUS_URL=$1
configure-nexus"
done
wait
}
+get_nodes() {
+ if [ -n "$PROVISION_ID" ]; then
+ # shellcheck disable=SC2207
+ NODES=(`$DOCKER_COMPOSE_CMD -p $PROVISION_ID ps -q`)
+ fi
Review comment:
I am open to any suggestion, I have basically wrapped what was there in
a function.. What do you have in mind? I can incorporate it in the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
