evans-ye commented on a change in pull request #851:
URL: https://github.com/apache/bigtop/pull/851#discussion_r783175301
##########
File path: provisioner/docker/docker-hadoop.sh
##########
@@ -284,12 +293,19 @@ log() {
}
configure-nexus() {
+ get_nodes
for node in ${NODES[*]}; do
docker exec $node bash -c "cd /bigtop-home; ./gradlew -PNEXUS_URL=$1
configure-nexus"
done
wait
}
+get_nodes() {
+ if [ -n "$PROVISION_ID" ]; then
+ # shellcheck disable=SC2207
+ NODES=(`$DOCKER_COMPOSE_CMD -p $PROVISION_ID ps -q`)
+ fi
Review comment:
My bad for not being clear. I was thinking that for the else case
(PROVISION_ID is not set), we can error out earlier with a clear log message
instead of being silence . But this is a minor comment as we didn't do this
kind of early error out in other place, plus you're just wrapping what
originally written ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
