iwasakims commented on code in PR #970:
URL: https://github.com/apache/bigtop/pull/970#discussion_r932938627
##########
bigtop-packages/src/common/hive/do-component-build:
##########
@@ -36,12 +36,12 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# for non-x86 platforms
if [ $HOSTTYPE = "powerpc64le" ] ; then
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc
-Dversion=2.5.0 \
- -Dclassifier=linux-ppcle_64 -Dpackaging=exe -Dfile=/usr/local/bin/protoc
+ -Dclassifier=linux-ppcle_64 -Dpackaging=exe
-Dfile=/usr/local/protobuf-2.5.0/bin/protoc
elif [ $HOSTTYPE = "aarch64" ] ; then
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc
-Dversion=2.5.0 \
- -Dclassifier=linux-aarch_64 -Dpackaging=exe -Dfile=/usr/local/bin/protoc
+ -Dclassifier=linux-aarch_64 -Dpackaging=exe
-Dfile=/usr/local/protobuf-2.5.0/bin/protoc
fi
-export MAVEN_OPTS="${MAVEN_OPTS} -Xmx1500m -Xms1500m"
+export MAVEN_OPTS="${MAVEN_OPTS} -Xmx2500m -Xms2500m"
Review Comment:
How about removing `-Xms1500m` to make JVM allocate heap on demand? We can
not expect much gain by allocating maximum heap from the beginning for short
term task like building products. I got no OOM with current settings on my
x86_64 environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
