iwasakims commented on code in PR #970:
URL: https://github.com/apache/bigtop/pull/970#discussion_r932974141
##########
bigtop-packages/src/common/hive/do-component-build:
##########
@@ -36,12 +36,12 @@ HIVE_MAVEN_OPTS=" -Dhbase.version=$HBASE_VERSION \
# for non-x86 platforms
if [ $HOSTTYPE = "powerpc64le" ] ; then
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc
-Dversion=2.5.0 \
- -Dclassifier=linux-ppcle_64 -Dpackaging=exe -Dfile=/usr/local/bin/protoc
+ -Dclassifier=linux-ppcle_64 -Dpackaging=exe
-Dfile=/usr/local/protobuf-2.5.0/bin/protoc
elif [ $HOSTTYPE = "aarch64" ] ; then
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc
-Dversion=2.5.0 \
- -Dclassifier=linux-aarch_64 -Dpackaging=exe -Dfile=/usr/local/bin/protoc
+ -Dclassifier=linux-aarch_64 -Dpackaging=exe
-Dfile=/usr/local/protobuf-2.5.0/bin/protoc
fi
-export MAVEN_OPTS="${MAVEN_OPTS} -Xmx1500m -Xms1500m"
+export MAVEN_OPTS="${MAVEN_OPTS} -Xmx2500m -Xms2500m"
Review Comment:
While `-Xmx2500m` might be still useful to allocate enough heap on machine
with memory less than 5GB (because the default maximum heap of JVM is capped at
half of the machine's memory IIRC), we can not practically use such a small
machine for Bigtop development. I think dropping `-Xmx` too should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
