guyuqi commented on code in PR #968:
URL: https://github.com/apache/bigtop/pull/968#discussion_r932966508


##########
bigtop_toolchain/manifests/packages.pp:
##########
@@ -63,7 +63,10 @@
         "libffi-devel",
         "krb5-devel",
         "net-tools",
-        "perl-Digest-SHA"
+        "perl-Digest-SHA",
+        "centos-release-scl",
+        "ninja-build",
+        "glibc-devel.i686"

Review Comment:
   `glibc-devel.i686` is just for x86 on Centos-7. 
   In this conditional branch(`centos|fedora|redhat `), it doesn't work for the 
other Distros and the other architectures(`Arm64 `and `ppcle64`).
   @kevinw66 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to