guyuqi commented on code in PR #968:
URL: https://github.com/apache/bigtop/pull/968#discussion_r932993612
##########
bigtop_toolchain/manifests/packages.pp:
##########
@@ -63,7 +63,10 @@
"libffi-devel",
"krb5-devel",
"net-tools",
- "perl-Digest-SHA"
+ "perl-Digest-SHA",
+ "centos-release-scl",
+ "ninja-build",
+ "glibc-devel.i686"
Review Comment:
The package name should be `glibc-devel` , not `glibc-devel.i686` in
`el7/el8`.
We don't need to add the Arch-suffix like `i686, x86_64, aarch64` here.
**x86:**
```
[root@e1d942388e90 bigtop]# yum search glibc-devel
│···························································
================================================== N/S matched: glibc-devel
==================================================│···························································
glibc-devel.i686 : Object files for development using standard C libraries.
│···························································
glibc-devel.x86_64 : Object files for development using standard C
libraries.
```
**Arm64:**
```
[root@b10f51b7ee3d workspace]# yum search glibc-devel
│·······················································
============================================================== N/S matched:
glibc-devel
===============================================================│·······················································
glibc-devel.aarch64 : Object files for development using standard C
libraries.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]