guyuqi commented on code in PR #1053: URL: https://github.com/apache/bigtop/pull/1053#discussion_r1023464057
########## bigtop-packages/src/common/phoenix/patch1-phoenix-hbase-compat.diff: ########## @@ -0,0 +1,69 @@ +diff --git a/phoenix-hbase-compat-2.4.1/pom.xml b/phoenix-hbase-compat-2.4.1/pom.xml +index de397d869..ead8bcf9c 100644 +--- a/phoenix-hbase-compat-2.4.1/pom.xml ++++ b/phoenix-hbase-compat-2.4.1/pom.xml +@@ -31,7 +31,7 @@ + <description>Compatibility module for HBase 2.4.1+</description> + + <properties> +- <hbase24.compat.version>2.4.1</hbase24.compat.version> ++ <hbase24.compat.version>2.4.13</hbase24.compat.version> + </properties> + + <dependencies> +diff --git a/pom.xml b/pom.xml +index b0a36925e..7a7887170 100644 +--- a/pom.xml ++++ b/pom.xml +@@ -80,10 +80,11 @@ + <!-- Hadoop and Hbase-thirdparty version --> + <!-- These are expected to be overridden to conform to cluster versions + along with hbase.version (defined in profiles) --> +- <hadoop.version>3.1.4</hadoop.version> +- <hbase.thirdparty.version>2.2.1</hbase.thirdparty.version> ++ <hadoop.version>3.3.4</hadoop.version> Review Comment: > Could you elaborate on the errors caused without this patch? @guyuqi Ambari mertrics (ams) collector intergrated Hadoop, Hbase and Phoenix and it would start ams-hbase/ams-hbase-regionserver services. Ams includes dependency of **phoenix-hbase-compat-2.4.1.jar** which needs this patch to adjust versions. It seems versions adjustion in [do-component-build](https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/phoenix/do-component-build) doesn't work for the module of `phoenix-hbase-compat-2.4.1`. Then phoenix would fail to connect hbase and there are some confused dependencies and cyclic reference issues reported from intergrated Hadoop, Hbase Class `AbstractMethodError `when ams collector starting. As the comments on BIGTOP-3872, we also need to find a place (Bigtop public repo) to store these Binary-TARs as Hortonworks did for our Bigtop + Ambari stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
