iwasakims commented on code in PR #1251:
URL: https://github.com/apache/bigtop/pull/1251#discussion_r1558632112
##########
docker/bigtop-puppet/build.sh:
##########
@@ -61,7 +61,8 @@ case "${OS}-${VERSION}" in
;;
openeuler-22.03*)
OPENEULER_OS="${OS}/${OS}"
- sed -i -e "s|${OS}:${VERSION}|$OPENEULER_OS:${VERSION}|" ./Dockerfile
+ # BIGTOP-4082 specify the openEuler OS version is : 22.03-lts-sp1
+ sed -i -e "s|${OS}:${VERSION}|$OPENEULER_OS:${VERSION}-lts-sp1|"
./Dockerfile
Review Comment:
@MacChen01 How about setting the VERSION by `VERSION=$(echo "$1" | cut -d
'-' -f 3-)` in line 32? We can avoid hardcoding the version into the script by
that. I'm expecting we can specify the version like
```
$ gradlew bigtop-puppet -POS=openeuler-22.03-lts-sp1 -Pprefix=3.3.0`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
