iwasakims commented on code in PR #1251:
URL: https://github.com/apache/bigtop/pull/1251#discussion_r1558921970
##########
docker/bigtop-puppet/build.sh:
##########
@@ -61,7 +61,8 @@ case "${OS}-${VERSION}" in
;;
openeuler-22.03*)
OPENEULER_OS="${OS}/${OS}"
- sed -i -e "s|${OS}:${VERSION}|$OPENEULER_OS:${VERSION}|" ./Dockerfile
+ # BIGTOP-4082 specify the openEuler OS version is : 22.03-lts-sp1
+ sed -i -e "s|${OS}:${VERSION}|$OPENEULER_OS:${VERSION}-lts-sp1|"
./Dockerfile
Review Comment:
I don't like to update the code every time we change the version used (e.g.
22.03-lts-sp2 in the future).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
