JiaLiangC commented on code in PR #1244:
URL: https://github.com/apache/bigtop/pull/1244#discussion_r1577599153
##########
bigtop-deploy/puppet/manifests/python.pp:
##########
@@ -20,4 +20,12 @@
target => '/usr/bin/python2',
}
}
+
+ # BIGTOP-4069 create the soft link of python for openEuler smoke-tests
+ if (($operatingsystem == 'openEuler' )) {
+ file { '/usr/bin/python':
+ ensure => 'link',
+ target => '/usr/bin/python3',
+ }
+ }
Review Comment:
> python3-unversioned-command seems to be provided for the purpose in
openEuler too. How about installing it? @MacChen01
>
> ```
> [root@929191cea27f /]# dnf install python3-unversioned-command
>
> [root@929191cea27f /]# rpm -q -f /usr/bin/python
> python3-unversioned-command-3.9.9-28.oe2203sp3.x86_64
>
> [root@929191cea27f /]# ls -lh /usr/bin/python
> lrwxrwxrwx 1 root root 16 Dec 28 05:49 /usr/bin/python -> /usr/bin/python3
> ```
@iwasakims
I think using symbolic links to ensure all systems have /usr/bin/python ->
/usr/bin/python3 in packages.pp offers stronger universality because not all
systems support python3-unversioned-command. This is also the approach I took
in BIGTOP-4098.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
