iwasakims commented on code in PR #1244:
URL: https://github.com/apache/bigtop/pull/1244#discussion_r1577604881


##########
bigtop-deploy/puppet/manifests/python.pp:
##########
@@ -20,4 +20,12 @@
           target => '/usr/bin/python2',
         }
     }
+    
+    # BIGTOP-4069 create the soft link of python for openEuler smoke-tests
+    if (($operatingsystem == 'openEuler' )) {
+        file { '/usr/bin/python':
+          ensure => 'link',
+          target => '/usr/bin/python3',
+        }
+    }

Review Comment:
   > stronger universality because not all systems support 
python3-unversioned-command
   
   We don't need to worry about other distros by conditional like `if 
(($operatingsystem == 'openEuler' )) {`. We usually avoid overwriting the file 
provided by standard packages of the OS distribution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to