On 4 February 2014 05:24, Olemis Lang <[email protected]> wrote: > On 2/3/14, Olemis Lang <[email protected]> wrote: >> On Sat, Feb 1, 2014 at 9:52 PM, Saint Germain <[email protected]> wrote: >> > [...] >> >>> May I ask the mailing-list to perform a review of this patch ? >>> >>> >> I'll take a look later today . >> > > Just a question , will you eventually merge your patches in > trac11338_language_prefix and t694_bh_i18n branches in MQ repos ? Both > branches are about i18n so I guess merging into t694_bh_i18n actually > makes sense . >
trac11338_language_prefix is a patch on Trac to implement language detection based on URL prefix (example.com/fr/... will set the default language to french for instance). See relevant Trac ticket here: http://trac.edgewall.org/ticket/11338 It has non-trivial impact on the way the URL are processed and I am not sure that this is ready yet (as far as I know, nobody looked at it yet). Especially given that I am not used to Trac dev and my method may not be good at all. There may also be security issue (maybe an URL with a strange language code) and regression issue (perhaps some language code conflict with some Trac URL). Anyway I thought that was a good idea to be able to link an URL directly to a page in a specific language. With the Multi-language support in the wiki (http://trac.edgewall.org/ticket/1513) it would be great. Regards,
