Hi Dammina, I made a few minor comments, nothing big, I think we are almost there.
I tried running the unit tests on bloodhound trunk. There are some things that need fixing. I will try to spend some time on that in the coming week. - Ryan On Thu, Dec 8, 2016 at 10:20 PM Dammina Sahabandu <dmsahaba...@gmail.com> wrote: Hi Ryan, I went through the review comments and did the required changes on a new branch trac-1.0.13-integration.1 [1]. Please have a look at it and give me a feedback whenever you are free. I'll create the required tickets on Trac in-order to back port the relevant changes soon. [1] https://github.com/dammina/bloodhound/tree/trac-1.0.13-integration.1 Thanks, Dammina On Sun, Dec 4, 2016 at 4:01 PM, Ryan J Ollos <rjol...@apache.org> wrote: > On Tue, Oct 4, 2016 at 9:14 PM Dammina Sahabandu <dmsahaba...@gmail.com> > wrote: > >> Hi Ryan, >> >> May I send a pull request so that you can review it easily and comment. >> >> Thanks, >> Dammina >> > > Very nice work! I'm very sorry for the long delay, and I really appreciate > you doing this work because this has been on my TODO list for a long time. > > I commented on the changeset with some suggestions. Please make a new > branch trac-1.0.13-integration.1 with the changes and resubmit for a > second round of review. > > I plan to release Trac 1.0.14 this weekend, so we'll probably want to > rebase the changes on that. I've made #660 the only open ticket for Release > 9. After we integrate these changes we can make a new release. > https://issues.apache.org/bloodhound/ticket/660 > > - Ryan > > -- Dammina Sahabandu SSE, AdroitLogic (pvt) Ltd. Committer, Apache Software Foundation AMIE (SL) Bsc Eng Hons (Moratuwa) +94716422775 <+94%2071%20642%202775>
