[
https://issues.apache.org/jira/browse/BOOKKEEPER-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235882#comment-14235882
]
Hadoop QA commented on BOOKKEEPER-809:
--------------------------------------
Testing JIRA BOOKKEEPER-809
Patch
[BOOKKEEPER-809.patch|https://issues.apache.org/jira/secure/attachment/12685024/BOOKKEEPER-809.patch]
downloaded at Fri Dec 5 18:15:26 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
. {color:red}WARNING: the current HEAD has 1 RAT warning(s), they should be
addressed ASAP{color}
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 933
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/866/
> Wrong metric on LedgerDeleteOp and LedgerOpenOp
> -----------------------------------------------
>
> Key: BOOKKEEPER-809
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-809
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.3.0
> Reporter: Charles Xie
> Assignee: Charles Xie
> Fix For: 4.4.0, 4.3.1
>
> Attachments: BOOKKEEPER-809.patch
>
>
> These two operations uses startTime as the latency for metric, which is
> wrong.
> {code}
> void openComplete(int rc, LedgerHandle lh) {
> if (BKException.Code.OK != rc) {
> openOpLogger.registerFailedEvent(startTime);
> } else {
> openOpLogger.registerSuccessfulEvent(startTime);
> }
> cb.openComplete(rc, lh, ctx);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
