[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236660#comment-14236660
 ] 

Hudson commented on BOOKKEEPER-809:
-----------------------------------

FAILURE: Integrated in bookkeeper-master #873 (See 
[https://builds.apache.org/job/bookkeeper-master/873/])
BOOKKEEPER-809: Wrong metric on LedgerDeleteOp and LedgerOpenOp (Charles Xie 
via sijie) (sijie: rev 0dfb4fb94d0ccc98e1050f662712d85bcf2003b1)
* 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java
* bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
BOOKKEEPER-809: Wrong metric on LedgerDeleteOp and LedgerOpenOp (Charles Xie 
via sijie) (missing CHANGES.txt) (sijie: rev 
ff5d2c5125d7d7fbe48d7935524820c55a887124)
* CHANGES.txt


> Wrong metric on LedgerDeleteOp and LedgerOpenOp
> -----------------------------------------------
>
>                 Key: BOOKKEEPER-809
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-809
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>    Affects Versions: 4.3.0
>            Reporter: Charles Xie
>            Assignee: Charles Xie
>             Fix For: 4.4.0, 4.3.1
>
>         Attachments: BOOKKEEPER-809.patch
>
>
> These two operations uses startTime as the latency for metric, which is 
> wrong. 
> {code}
>     void openComplete(int rc, LedgerHandle lh) {
>         if (BKException.Code.OK != rc) {
>             openOpLogger.registerFailedEvent(startTime);
>         } else {
>             openOpLogger.registerSuccessfulEvent(startTime);
>         }
>         cb.openComplete(rc, lh, ctx);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to