[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333056#comment-14333056
 ] 

Sijie Guo commented on BOOKKEEPER-836:
--------------------------------------

I like the idea to disable compaction when the disk becomes full, especially we 
should disable major compaction. because it basically fills up disk spaces more 
quickly.

we could do lowering threshold or aggressive release space. but at least we 
should be allow people to turn off compaction when disks become full.

> disable compaction when disk becomes full, otherwise compaction will fill up 
> disk quickly
> -----------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-836
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-836
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>    Affects Versions: 4.2.3
>            Reporter: Jia Zhai
>            Assignee: Jia Zhai
>             Fix For: 4.4.0, 4.3.2
>
>         Attachments: BOOKKEEPER-836.patch
>
>
> In doCompactEntryLogs, Entries are added to new logs, while all old logs were 
> not released until the end of handling.  So during the process, a lot of 
> space will be used. Need to disable compaction when disk becomes full, 
> otherwise compaction will fill up disk quickly.
> I would like to change old "forced garbage collection" logic, and suspend 
> major compaction when it reaches warn threshold, suspend minor compaction 
> when it reaches critical threshold.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to