[ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504598#comment-14504598 ]
Hudson commented on BOOKKEEPER-836: ----------------------------------- SUCCESS: Integrated in bookkeeper-master #1028 (See [https://builds.apache.org/job/bookkeeper-master/1028/]) BOOKKEEPER-836: disable compaction when disk becomes full, otherwise compaction will fill up disk quickly (zhaijia via sijie) (sijie: rev e0d331781ec7a0e415bc6f16c38686aab34cb0c5) * bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java * bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java * CHANGES.txt * bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java * bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java > disable compaction when disk becomes full, otherwise compaction will fill up > disk quickly > ----------------------------------------------------------------------------------------- > > Key: BOOKKEEPER-836 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-836 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server > Affects Versions: 4.2.3 > Reporter: Jia Zhai > Assignee: Jia Zhai > Fix For: 4.4.0 > > Attachments: BOOKKEEPER-836-v2.patch, BOOKKEEPER-836-v3.patch, > BOOKKEEPER-836.patch > > > In doCompactEntryLogs, Entries are added to new logs, while all old logs were > not released until the end of handling. So during the process, a lot of > space will be used. Need to disable compaction when disk becomes full, > otherwise compaction will fill up disk quickly. > I would like to change old "forced garbage collection" logic, and suspend > major compaction when it reaches warn threshold, suspend minor compaction > when it reaches critical threshold. -- This message was sent by Atlassian JIRA (v6.3.4#6332)