[
https://issues.apache.org/jira/browse/BOOKKEEPER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395289#comment-14395289
]
Flavio Junqueira commented on BOOKKEEPER-833:
---------------------------------------------
Sijie, A couple of comments on the patch:
# It is a bit odd that we force preallocatedLogId to be no more that
Integer.MAX_VALUE since it is long. Should we make it an int if it needs to fit
in 4 bytes then?
# This comment confused me: "The only exception for the size limitation is if a
file grows to be more than 4GB". Aren't you limiting the log size to be no more
than 1GB in this patch?
> EntryLogId and EntryLogLimit should not be larger than Integer.MAX_VALUE
> ------------------------------------------------------------------------
>
> Key: BOOKKEEPER-833
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-833
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Priority: Blocker
> Fix For: 4.4.0, 4.3.1
>
> Attachments: BOOKKEEPER-833.patch
>
>
> currently the index entry position is combined with log id and entry offset
> inside a log. so it means that log id and entry log file size shouldn't be
> larger than Integer.MAX_VALUE. otherwise, it would cause trouble.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
