[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493753#comment-14493753
 ] 

Sijie Guo commented on BOOKKEEPER-833:
--------------------------------------

> Should we make it an int if it needs to fit in 4 bytes then?

good point. making the change.

> The only exception for the size limitation is if a file grows to be more than 
> 4GB

need to address the comments.

> EntryLogId and EntryLogLimit should not be larger than Integer.MAX_VALUE
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-833
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-833
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>            Priority: Blocker
>             Fix For: 4.4.0, 4.3.1
>
>         Attachments: BOOKKEEPER-833.patch
>
>
> currently the index entry position is combined with log id and entry offset 
> inside a log. so it means that log id and entry log file size shouldn't be 
> larger than Integer.MAX_VALUE. otherwise, it would cause trouble.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to