> On April 14, 2015, 7:37 a.m., Sijie Guo wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java, > > line 426 > > <https://reviews.apache.org/r/33061/diff/1/?file=922608#file922608line426> > > > > could you move #appendLedgerMap() to flushRotatedLogs()? so > > appendLedgerMap happens only on checkpointing, rather than when rolling > > log. because rolling log happens in critical path which will impact latency. > > Matteo Merli wrote: > The problem is that on flushRotatedLogs() we have a list of > BufferedLogChannel. I'll change it to keep the EntryLogMetadata in the > BufferedLogChannel, so we can have multiple outstanding to be flushed.
Actually, the bigger issue is that when an entry log is rotated, the garbage collector will try to read index and since it doesn't find it, will scan the entry log. I'll change it back again to do appendLedgersMap() in flushRotatedLogs() - Matteo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33061/#review79997 ----------------------------------------------------------- On April 14, 2015, 11:28 p.m., Matteo Merli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33061/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 11:28 p.m.) > > > Review request for bookkeeper. > > > Bugs: BOOKKEEPER-841 > https://issues.apache.org/jira/browse/BOOKKEEPER-841 > > > Repository: bookkeeper-git > > > Description > ------- > > Bookie should calculate ledgers map when writing a new entry log file. so the > bookie doesn't need to scan that entry log file again, which it would improve > garbage collection efficiency > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogMetadata.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java > 0e052b5 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java > 299fb3e > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java > 0a3884c > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java > 488f4bf > > Diff: https://reviews.apache.org/r/33061/diff/ > > > Testing > ------- > > > Thanks, > > Matteo Merli > >
