----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33061/#review84274 -----------------------------------------------------------
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135471> rename ledgersMap to ledgersMapBuffer? because ledgersMap makes people thinking it is a map. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135469> could you add entry log id in the IOExcpetion's error message? bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135470> could you add entry log id in the IOExcpetion's error message? bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135472> ledgersMap.getLong() will throw BufferUnderflowException, which is a runtime exception. it should be handled. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135473> ledgersMap.getLong() will throw BufferUnderflowException, which is a runtime exception. it should be handled. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135474> add entry log id in error message? bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java <https://reviews.apache.org/r/33061/#comment135475> add entry log id in error message bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java <https://reviews.apache.org/r/33061/#comment135477> why change here? the checkpointSource passed to super would be null - Sijie Guo On April 15, 2015, 5:37 p.m., Matteo Merli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33061/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 5:37 p.m.) > > > Review request for bookkeeper. > > > Bugs: BOOKKEEPER-841 > https://issues.apache.org/jira/browse/BOOKKEEPER-841 > > > Repository: bookkeeper-git > > > Description > ------- > > Bookie should calculate ledgers map when writing a new entry log file. so the > bookie doesn't need to scan that entry log file again, which it would improve > garbage collection efficiency > > > Diffs > ----- > > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogMetadata.java > PRE-CREATION > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java > 0e052b5 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java > 299fb3e > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java > 0a3884c > > bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java > 488f4bf > > Diff: https://reviews.apache.org/r/33061/diff/ > > > Testing > ------- > > > Thanks, > > Matteo Merli > >
