Here are the patches, and tests are not failing for me; Should I upload these? Please advise. Changed hashCode as per your advise and findbugs:findbugs did not find any issue now or even before. I am running Java 7; could that be an issue?
On Sat, Oct 17, 2015 at 3:19 PM, Venkateswara Rao Jujjuri <jujj...@gmail.com > wrote: > Strange; looking into the issue. > > On Sat, Oct 17, 2015 at 2:19 PM, Hadoop QA (JIRA) <j...@apache.org> wrote: > >> >> [ >> https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962087#comment-14962087 >> ] >> >> Hadoop QA commented on BOOKKEEPER-867: >> -------------------------------------- >> >> Testing JIRA BOOKKEEPER-867 >> >> >> Patch >> [noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch| >> https://issues.apache.org/jira/secure/attachment/12767228/noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch] >> downloaded at Sat Oct 17 20:39:02 UTC 2015 >> >> ---------------------------- >> >> {color:green}+1 PATCH_APPLIES{color} >> {color:green}+1 CLEAN{color} >> {color:green}+1 RAW_PATCH_ANALYSIS{color} >> . {color:green}+1{color} the patch does not introduce any @author tags >> . {color:green}+1{color} the patch does not introduce any tabs >> . {color:green}+1{color} the patch does not introduce any trailing >> spaces >> . {color:green}+1{color} the patch does not introduce any line longer >> than 120 >> . {color:green}+1{color} the patch does adds/modifies 1 testcase(s) >> {color:green}+1 RAT{color} >> . {color:green}+1{color} the patch does not seem to introduce new RAT >> warnings >> {color:green}+1 JAVADOC{color} >> . {color:green}+1{color} the patch does not seem to introduce new >> Javadoc warnings >> {color:green}+1 COMPILE{color} >> . {color:green}+1{color} HEAD compiles >> . {color:green}+1{color} patch compiles >> . {color:green}+1{color} the patch does not seem to introduce new >> javac warnings >> {color:red}-1 FINDBUGS{color} >> . {color:red}-1{color} the patch seems to introduce 1 new Findbugs >> warning(s) in module(s) [bookkeeper-server] >> {color:red}-1 TESTS{color} >> . Tests run: 924 >> . Tests failed: 2 >> . Tests errors: 5 >> >> . The patch failed the following testcases: >> >> . >> testDuplicateEnDisableAutoRecovery[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest) >> . >> testReadOnlyBookieExclusionFromURLedgersCheck[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest) >> >> {color:green}+1 DISTRO{color} >> . {color:green}+1{color} distro tarball builds with the patch >> >> ---------------------------- >> {color:red}*-1 Overall result, please check the reported -1(s)*{color} >> >> >> The full output of the test-patch run is available at >> >> . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/965/ >> >> > New Client API to allow applications pass-in EntryId. >> > ----------------------------------------------------- >> > >> > Key: BOOKKEEPER-867 >> > URL: >> https://issues.apache.org/jira/browse/BOOKKEEPER-867 >> > Project: Bookkeeper >> > Issue Type: Sub-task >> > Components: bookkeeper-client >> > Affects Versions: 4.3.1 >> > Reporter: Venkateswararao Jujjuri >> > Assignee: Venkateswararao Jujjuri >> > Labels: features, newbie >> > Fix For: 4.4.0 >> > >> > Attachments: >> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> BOOKKEEPER-867.patch, >> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch, >> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch >> > >> > >> >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332) >> > > > > -- > Jvrao > --- > First they ignore you, then they laugh at you, then they fight you, then > you win. - Mahatma Gandhi > > > -- Jvrao --- First they ignore you, then they laugh at you, then they fight you, then you win. - Mahatma Gandhi
