[
https://issues.apache.org/jira/browse/BOOKKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965224#comment-14965224
]
Sijie Guo commented on BOOKKEEPER-867:
--------------------------------------
I ran the test-patch locally. it seems to pass the findbugs checking. but
failed with two long lines (doAsyncAddEntry in LedgerHandleAdv and
getLedgerMetadata in BookieWriteLedgerTest)
- I will check why pre-commit job doesn't catch long lines but fail with
findbugs
- [~jujjuri] could you fix the long lines? you could run "bin/test-patch
--patch=${patch_file_path} --dirty-scm" in you clean master repo. it would give
you a detail report under test-patch directory.
> New Client API to allow applications pass-in EntryId.
> -----------------------------------------------------
>
> Key: BOOKKEEPER-867
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-867
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client
> Affects Versions: 4.3.1
> Reporter: Venkateswararao Jujjuri
> Assignee: Venkateswararao Jujjuri
> Labels: features, newbie
> Fix For: 4.4.0
>
> Attachments:
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> 0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> BOOKKEEPER-867.patch,
> git-format-patch-norefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch,
> noprefix-0001-BOOKKEEPER-867-New-Client-API-to-allow-applications-.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
