Lgtm +1 I checked licenses and sigs and ran through the build. There's some flake in benchmark and hedwig-jms, but I wouldn't block the release for this. However, these modules are unsupported, especially hedwig-jms, so they should be removed from the next release, or at least their tests should be disabled.
Good work Matteo! -Ivan On Tue, Nov 24, 2015 at 10:00 AM, Sijie Guo <[email protected]> wrote: > +1, looks good to me. > > - check the binaries > - check the source code (benchmark module seems to be problematic to me, > but it is fine) > - check versions, repositories > > - Sijie > > On Tue, Nov 17, 2015 at 2:39 PM, Matteo Merli <[email protected]> wrote: > >> This is the second release candidate for Apache BookKeeper, version 4.3.2. >> >> It fixes the following issues: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12333529&styleName=Html&projectId=12311293 >> >> *** Please download, test and vote by November 21th 2015, 10:00 GMT. >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary files: >> >> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.3.2-candidate-1/ >> >> Maven staging repo: >> >> https://repository.apache.org/content/repositories/orgapachebookkeeper-1009/ >> >> The tag to be voted upon: >> release-4.3.2 (86538192a08b8629e9c1487dcc9afae95a51705f) >> >> BookKeeper's KEYS file containing PGP keys we use to sign the release: >> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS >> >> Please download the the source package, and follow the README to build >> and run a bookkeeper and hedwig service. >> >> Thanks, >> Matteo >>
