[
https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035443#comment-15035443
]
Sijie Guo commented on BOOKKEEPER-877:
--------------------------------------
[~jiannan] I've documented this in the
https://cwiki.apache.org/confluence/display/BOOKKEEPER/BookKeeper+Patch+Review+Tool.
is it good enough? for git diff and git format-patch, I don't have too much
preference. it might be much easier for reviewer to review on a single patch
file (git diff) rather than a file with multiple patches (git format). but the
patch would eventually be displayed in reviewboard. so that should be fine,
right?
> Script for generating patch for reviews
> ---------------------------------------
>
> Key: BOOKKEEPER-877
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-877
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Attachments: BOOKKEEPER-877.patch,
> BOOKKEEPER-877_2015-11-12_00:26:23.patch,
> BOOKKEEPER-877_2015-11-12_00:28:08.patch,
> BOOKKEEPER-877_2015-11-12_00:52:03.patch
>
>
> It would be good to have a script to generate patch for reviews.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
