[
https://issues.apache.org/jira/browse/BOOKKEEPER-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035599#comment-15035599
]
Jiannan Wang commented on BOOKKEEPER-877:
-----------------------------------------
That's quite a detailed document! I have no further comment.
For git diff and git format-patch, git diff does not generate binary changes,
which might be a problem (the uploaded patch is not complete). Otherwise, I'm
ok with it.
> Script for generating patch for reviews
> ---------------------------------------
>
> Key: BOOKKEEPER-877
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-877
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Attachments: BOOKKEEPER-877.patch,
> BOOKKEEPER-877_2015-11-12_00:26:23.patch,
> BOOKKEEPER-877_2015-11-12_00:28:08.patch,
> BOOKKEEPER-877_2015-11-12_00:52:03.patch
>
>
> It would be good to have a script to generate patch for reviews.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
