[
https://issues.apache.org/jira/browse/BOOKKEEPER-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198263#comment-15198263
]
Charan Reddy Guttapalem commented on BOOKKEEPER-894:
----------------------------------------------------
My Apologies for my late feedback, I've few questions here
- For printing the contents of the Entry, HexDumpFormat is used by default
here, but whereas in ReadJournalCmd/ReadLogCmd StringEntryFormatter is used and
it is configurable. Not sure if we should be ok with the discrepancy here. IMO
we should add HexDumpEntryFormatter just like StringEntryFormatter and use the
configured formatter for printing the entry.
- Its not clear why asyncReadEntries is used for reading the entries when
anyhow we are blocking for the response. Instead we can simply use sync
version, right?
- Also here, asyncReadEntries is called for each entryId (from start_entry_Id
to end_entry_id), is this really required? IMO it is perf issue
> Read ledger entries from the bookie shell
> -----------------------------------------
>
> Key: BOOKKEEPER-894
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-894
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.3.2
> Reporter: Siddharth Sunil Boobna
> Assignee: Siddharth Sunil Boobna
> Priority: Minor
> Fix For: 4.4.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Bookie Shell should have a tool to read ledger entries from the bookkeeper
> cluster with optional arguments of startEntryId and endEntryId.
> Solution:
> We implement readEntries() in BookKeeperAdmin and return an Iterable. While
> iterating through it, we fetch individual entries instead of fetching all
> entries at once. Also, if the lastEntryId is not specified, we read entries
> till we get a NoSuchEntryException
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
