[
https://issues.apache.org/jira/browse/BOOKKEEPER-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198313#comment-15198313
]
Sijie Guo commented on BOOKKEEPER-894:
--------------------------------------
This is from the reviewer's perspective. [~merlimat] could chime in.
Re. the format issue: could you file a jira to consolidate them?
Re: asyncReadEntries : it used asyncReadEntriesInternal to by pass the sanity
check of lastAddConfirmed in the admin tool.
Re: performance: in general, it is recommended that a tool should not overwhelm
any online traffic. It could be slow that read one by one, but it is actual
good for a tool. so that it won't send too many traffic to a bookie hence
overwhelm it.
> Read ledger entries from the bookie shell
> -----------------------------------------
>
> Key: BOOKKEEPER-894
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-894
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.3.2
> Reporter: Siddharth Sunil Boobna
> Assignee: Siddharth Sunil Boobna
> Priority: Minor
> Fix For: 4.4.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Bookie Shell should have a tool to read ledger entries from the bookkeeper
> cluster with optional arguments of startEntryId and endEntryId.
> Solution:
> We implement readEntries() in BookKeeperAdmin and return an Iterable. While
> iterating through it, we fetch individual entries instead of fetching all
> entries at once. Also, if the lastEntryId is not specified, we read entries
> till we get a NoSuchEntryException
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
