[
https://issues.apache.org/jira/browse/BOOKKEEPER-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224481#comment-15224481
]
Arun M. Krishnakumar commented on BOOKKEEPER-911:
-------------------------------------------------
It looks like the functionality of {{ReplicationWorker}} after the fix for
[BOOKKEEPER-594|https://issues.apache.org/jira/browse/BOOKKEEPER-594] is to not
to shutdown but to let the {{AutoRecoveryMain}} daemon do the job. Since the
current tests directly create the {{ReplicationWorker}} we run into these
issues. Some options are:
# Use the {{AutoRecoveryMain}} methods so that we can use the Zookeeper
session-expiry watcher it creates, and also use its shutdown methods. Such
cases are already covered in {{AutoRecoveryMainTest}}.
# What is the intent behind the removal of the {{shutdown()}} from the
{{UnavailableBookieHandling}} ? Is it the same as mentioned above ? Probably we
could change the code flow there.
[~rakeshr], [~merlimat] could you please advise ?
> Fix TestReplicationWorker tests in master
> -----------------------------------------
>
> Key: BOOKKEEPER-911
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-911
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.3.2
> Reporter: Arun M. Krishnakumar
> Assignee: Arun M. Krishnakumar
> Labels: tests
>
> Currently we have the following test failures in master branch:
> Results :
> Failed tests:
> testRWZKSessionLost[0](org.apache.bookkeeper.replication.TestReplicationWorker):
> Replication worker should have shut down
>
> testRWZKSessionLost[1](org.apache.bookkeeper.replication.TestReplicationWorker):
> Replication worker should have shut down
>
> testRWZKSessionLost[2](org.apache.bookkeeper.replication.TestReplicationWorker):
> Replication worker should have shut down
> Tests in error:
>
> testRWShutdownOnLocalBookieReadonlyTransition[0](org.apache.bookkeeper.replication.TestReplicationWorker):
> test timed out after 20000 milliseconds
>
> testRWShutdownOnLocalBookieReadonlyTransition[1](org.apache.bookkeeper.replication.TestReplicationWorker):
> test timed out after 20000 milliseconds
>
> testRWShutdownOnLocalBookieReadonlyTransition[2](org.apache.bookkeeper.replication.TestReplicationWorker):
> test timed out after 20000 milliseconds
> Tests run: 654, Failures: 3, Errors: 3, Skipped: 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
