[
https://issues.apache.org/jira/browse/BOOKKEEPER-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224568#comment-15224568
]
Arun M. Krishnakumar commented on BOOKKEEPER-911:
-------------------------------------------------
[~merlimat], the reason I ask this is: as per the comments, the
{{ReplicationWorker}} should shutdown in some cases but the code has a change
from [https://issues.apache.org/jira/browse/BOOKKEEPER-594] to explicitly not
do it. So it will be good to know if we should fix the tests or fix the code.
For example, one of the failing tests says:
{noformat}
/**
* Test that if the local bookie turns out to be readonly, then no point in
running RW. So RW should shutdown.
*/
{noformat}
And the code explicitly has a change to wait for the bookie to become writeable
in case there is a {{BKWriteOnReadOnlyBookieException}}.
> Fix TestReplicationWorker tests in master
> -----------------------------------------
>
> Key: BOOKKEEPER-911
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-911
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.3.2
> Reporter: Arun M. Krishnakumar
> Assignee: Arun M. Krishnakumar
> Labels: tests
>
> Currently we have the following test failures in master branch:
> Results :
> Failed tests:
> testRWZKSessionLost[0](org.apache.bookkeeper.replication.TestReplicationWorker):
> Replication worker should have shut down
>
> testRWZKSessionLost[1](org.apache.bookkeeper.replication.TestReplicationWorker):
> Replication worker should have shut down
>
> testRWZKSessionLost[2](org.apache.bookkeeper.replication.TestReplicationWorker):
> Replication worker should have shut down
> Tests in error:
>
> testRWShutdownOnLocalBookieReadonlyTransition[0](org.apache.bookkeeper.replication.TestReplicationWorker):
> test timed out after 20000 milliseconds
>
> testRWShutdownOnLocalBookieReadonlyTransition[1](org.apache.bookkeeper.replication.TestReplicationWorker):
> test timed out after 20000 milliseconds
>
> testRWShutdownOnLocalBookieReadonlyTransition[2](org.apache.bookkeeper.replication.TestReplicationWorker):
> test timed out after 20000 milliseconds
> Tests run: 654, Failures: 3, Errors: 3, Skipped: 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
