[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255106#comment-15255106
 ] 

Jia Zhai commented on BOOKKEEPER-924:
-------------------------------------

There seems an error contains the changed code in 
org.apache.bookkeeper.test.TestBackwardCompat.testCompat410.
https://builds.apache.org/job/bookkeeper-master-git-pullrequest/75/#showFailuresLink

org.junit.runners.model.TestTimedOutException: test timed out after 60000 
milliseconds
        at sun.misc.Unsafe.park(Native Method)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:994)
        at 
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1303)
        at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:236)
        at org.apache.bookkeeper.client.SyncCounter.block(SyncCounter.java:44)
        at 
org.apache.bookkeeper.client.LedgerHandle.addEntry(LedgerHandle.java:518)
        at 
org.apache.bookkeeper.client.LedgerHandle.addEntry(LedgerHandle.java:479)
        at 
org.apache.bookkeeper.test.TestBackwardCompat$LedgerCurrent.write100(TestBackwardCompat.java:446)
        at 
org.apache.bookkeeper.test.TestBackwardCompat.testCompat410(TestBackwardCompat.java:634)

> addEntry() is susceptible to spurious wakeups
> ---------------------------------------------
>
>                 Key: BOOKKEEPER-924
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-924
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.3.2
>            Reporter: Venkateswararao Jujjuri (JV)
>            Assignee: Venkateswararao Jujjuri (JV)
>            Priority: Critical
>             Fix For: 4.4.0
>
>
> LedgerHandle sync interface heavily depends on SyncCounter to convert async 
> interfaces
> into sync interfaces.
> Usaylly
> SyncCounter.inc()
> asyncCall()
> SyncCOunter.block(0)
> The block code is.
>    synchronized void block(int limit) throws InterruptedException {
>         while (i > limit) {
>             int prev = i;
>             wait();
>             if (i == prev) {
>                 break;
>             }
>         }
>     }
> Since 'i' is going to be same as 'prev' on spurious wakeup, and wait() can 
> return on spurious wakeups. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to