[
https://issues.apache.org/jira/browse/BOOKKEEPER-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352496#comment-15352496
]
Enrico Olivelli commented on BOOKKEEPER-937:
--------------------------------------------
I'm +1 in upgrading to 2.6 if it is compatibile.
.java files generated by protobuf compiler actually need to be committed as
they are never re-generated during builds
maybe it would be better to submit a Github PR using the new patch submission
flow
> Upgrade protobuf to 2.6
> -----------------------
>
> Key: BOOKKEEPER-937
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-937
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.5.0
> Reporter: Andrey Yegorov
> Priority: Minor
> Attachments: 0001-upgraded-protobuf-to-2.6.1.patch
>
>
> I had to update protobuf definition for some internal experiments and found
> that working with protobuf 2.4 is rather inconvenient. It cannot be installed
> with brew on mac and building it on mac always result is build errors hence
> leaves an option of switching to linux to run protoc.
> I decided to upgrade to 2.6 instead. It is compatible with 2.4 on wire and
> shaded so should not create any problems. All tests passed.
> Please ignore changes in java files in attached patch during review; these
> are auto-generated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
